search

letmaik / rawpy

📷 RAW image processing for Python, a wrapper for libraw
https://pypi.python.org/pypi/rawpy
MIT License
591 stars 67 forks source link

adjust_maximum_thr does not work #100

Closed olokobayusuf closed 4 years ago

olokobayusuf commented 4 years ago

Hi there. I'm using RawPy 0.14.0 with Python 3.6 and I'm trying to fix the purple sky issue: 731B0090

According to the LibRaw docs, setting adjust_maximum_thr should fix it. I've tried using this parameter in RawPy but no matter what I set this param to, nothing changes. I've tried -1, 0, 0.4, 1, 2.

params = Params(
        use_auto_wb=False,
        use_camera_wb=True,
        output_color=ColorSpace.sRGB,
        output_bps=8,
        no_auto_scale=False,
        no_auto_bright=True,
        adjust_maximum_thr=-1.0
)

macOS preview displays the CR2 file with the proper colors:

Screen Shot 2020-02-13 at 10 29 32 AM
letmaik commented 4 years ago

Can you link to the relevant part of the LibRaw docs?

olokobayusuf commented 4 years ago

On this page, search for adjust_maximum_thr.

olokobayusuf commented 4 years ago

Any word on this @letmaik ?

letmaik commented 4 years ago

Please don't post comments in short intervals asking about progress. We get enough emails already ;)

I don't know why adjust_maximum_thr does not have an effect, this value is simply passed down to libraw. I haven't used it myself, maybe others can comment?

olokobayusuf commented 4 years ago

Issue is at LibRaw, not RawPy. Fix (indirectly) addressed in #121/#122.