Closed kmilos closed 4 years ago
Is this equivalent to raw.raw_image.max()
?
Nope, if you're underexposed your raw data doesn't reach the saturation value, which is the one used for scaling.
Got it, stupid question. How come black level is per channel but white level is not?
Not sure, probably because it's not so critical for the color shift as if when you get the black level wrong... It's not per channel in the TIFF/EP or DNG spec either, only per plane.
Speaking of which, the only doubt I have is how to name this property: I went for ISO (TIFF/EP & DNG) tag terminology, but we could also go for e.g. sat_level
to align w/ dcraw/LibRaw terminology and existing user_sat
Let's keep white_level, it seems more consistent. But yes, the docstring for user_sat should be updated to clarify this. Currently it's :param int user_sat: saturation adjustment
. How about :param int user_sat: custom white level (saturation adjustment)
. This would make it more aligned with :param int user_black: custom black level
. I really wonder why libraw/dcraw calls it saturation and not white level. Are you absolutely sure these are the same concepts?
Thanks for digging this out! Really appreciate it.
Example: