search

letmaik / rawpy

📷 RAW image processing for Python, a wrapper for libraw
https://pypi.python.org/pypi/rawpy
MIT License
613 stars 68 forks source link

Include Jasper for Windows build #104

Closed kmilos closed 2 years ago

kmilos commented 4 years ago

Addresses https://github.com/letmaik/rawpy/issues/103

letmaik commented 4 years ago

Thanks for this. I had a look at the Windows CI failure ("DLL load failed: The specified module could not be found."), and this is because libjasper on conda-forge is only published as shared library, not as statically linked library. The issue can theoretically be fixed by copying the DLL to the right folder, but... unfortunately shared libraries have caused me/rawpy way too much pain in the past for Windows so I made the decision to only link against static libraries for Windows. Both libjpeg and zlib are available as static libraries on conda. Could you change the conda-forge repo to also build the statically linked library of libjasper for Windows? Then we can continue here.

kmilos commented 4 years ago

Yes, figured that was the problem... For Anaconda users dynamic linking should be ok, but I guess you want to cover a wider base. Requested at conda-forge, let's see...

letmaik commented 2 years ago

This PR won't be necessary anymore as I moved away from conda for dependencies and instead use vcpkg. See https://github.com/letmaik/rawpy/pull/150.

kmilos commented 2 years ago

Ok, makes sense to switch.