search

letmaik / rawpy

📷 RAW image processing for Python, a wrapper for libraw
https://pypi.python.org/pypi/rawpy
MIT License
587 stars 67 forks source link

Do not compile LibRaw for mingw #133

Closed kmilos closed 3 years ago

kmilos commented 3 years ago

Platform detection based on https://stackoverflow.com/a/51200002

Official CPython and Anaconda packages are built w/ MSVC.

letmaik commented 3 years ago

Can you explain the use case for this? Who is building rawpy under mingw and why?

kmilos commented 3 years ago

I could ;)

Mingw already ships all the requirements as shared libs (LibRaw, LCMS2, Jasper...) and could be a neat alternative to have all the features of rawpy on Windows.

After all, this doesn't change anything for your current wheel distribution, and avoids maintaining a separate patch in the mingw recipes repo...

kmilos commented 3 years ago

It builds and installs fine via pip on mingw, but I just hit a problem on import, so let's hold off a bit...

>>> import rawpy
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:/msys64/home/kmilos/rawpy_build/rawpy/__init__.py", line 5, in <module>
    import rawpy._rawpy
ModuleNotFoundError: No module named 'rawpy._rawpy'
kmilos commented 3 years ago

False alarm, as it turns out I was running from the source dir... No problem otherwise.

kmilos commented 3 years ago

Ta!