search

letmaik / rawpy

📷 RAW image processing for Python, a wrapper for libraw
https://pypi.python.org/pypi/rawpy
MIT License
587 stars 67 forks source link

Switch to `pytest` from `nose` #157

Closed occamz closed 2 years ago

occamz commented 2 years ago

In response to issue https://github.com/letmaik/rawpy/issues/156.

Kept the changes to a minimum and tried to mimic the setup as closely as possible.

As this is my first time contributing, please tell me if I'm doing something out of convention. I held back the urge to reformat the python files with black as that wasn't part of the issue I was resolving :D

occamz commented 2 years ago

There is one last reference to nose in setup.py which I'm uncertain about: https://github.com/letmaik/rawpy/blob/6dd8d8b21821012e5a94c9984b0efb6acb6fb256/setup.py#L264-L267

Should I just remove 'nosetests' from the list?

letmaik commented 2 years ago

There is one last reference to nose in setup.py which I'm uncertain about:

https://github.com/letmaik/rawpy/blob/6dd8d8b21821012e5a94c9984b0efb6acb6fb256/setup.py#L264-L267

Should I just remove 'nosetests' from the list?

Yes, just remove that. It's some left-over cruft from the past...

Looks good otherwise, thanks!