search

letmaik / rawpy

📷 RAW image processing for Python, a wrapper for libraw
https://pypi.python.org/pypi/rawpy
MIT License
587 stars 67 forks source link

build and test on arm64 mac #219

Closed jakevc closed 6 months ago

jakevc commented 6 months ago

Adds build and test CI for arm64 Mac

jakevc commented 6 months ago

Might fix #218 if build and test work on arm64

letmaik commented 6 months ago

Could you try this in your own fork first? I don't think this is correct and GitHub also hasn't released free arm64 Mac agents yet.

kmilos commented 6 months ago

GitHub also hasn't released free arm64 Mac agents yet.

Au conratire! Just last week: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Has to be macos-14 though, latest still points to 12 (Intel)...

As for the rest, seems overly complex indeed... Why not use a matrix instead of duplicating all this stuff?

letmaik commented 6 months ago

GitHub also hasn't released free arm64 Mac agents yet.

Au conratire! Just last week: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Has to be macos-14 though, latest still points to 12 (Intel)...

You're right, I totally missed that. That's great!

As for the rest, seems overly complex indeed... Why not use a matrix instead of duplicating all this stuff?

I wasn't able to express all the different cases with a matrix and it seemed that listing every config was more straight forward to manage.

jakevc commented 6 months ago

Passing build and test here now: https://github.com/jakevc/rawpy/actions/runs/7879645476

jakevc commented 6 months ago

All checks have passed for this

letmaik commented 6 months ago

Thanks! :)

jakevc commented 6 months ago

please release this version to PyPi when you get the chance