search

letmaik / rawpy

📷 RAW image processing for Python, a wrapper for libraw
https://pypi.python.org/pypi/rawpy
MIT License
587 stars 67 forks source link

Fix #228 #229

Open eroux opened 3 months ago

eroux commented 3 months ago

This is an updated version of https://github.com/letmaik/rawpy/pull/76 with a doc string and a test. Unfortunately when I run this version I'm currently getting a segfault on the test and I can't really debug it, help appreciated!

mplough-kobold commented 3 weeks ago

@eroux I believe that the segfault is happening because you're creating a Python callback and then attempting to run it inside a nogil context. As a result, a Python interpreter is not available for running the callback properly.

I solved the issue using an alternate method in #236; your test data was particularly useful in verifying that the method works. Thank you!

eroux commented 3 weeks ago

wonderful, thanks!