letmaik / vscode-git-tree-compare

🎄 VS Code extension for comparing the git working tree against a branch, tag, or commit, displayed as folder tree
https://marketplace.visualstudio.com/items?itemName=letmaik.git-tree-compare
MIT License
60 stars 7 forks source link

Does `virtualWorkspaces` needs to be `false`? #94

Closed xunilrj closed 1 year ago

xunilrj commented 1 year ago

Any reason virtualWorkspaces is not enabled? I manually put true and everything is working. This makes the extension not available in a lot of scenarios.

https://github.com/letmaik/vscode-git-tree-compare/blob/master/package.json#L35

letmaik commented 1 year ago

I'm not sure how the extension would work with virtual workspaces since it invokes the git binary and relies on an actual filesystem instead of a filesystem provider. Can you provide more details about your scenario?

xunilrj commented 1 year ago

If you start https://github.com/gitpod-io/openvscode-server, open the browser version of vscode and search for this extension, it does not appear. I think this happens because virtualWorkspaces is false.

But by manually installing the vsix, the extension works.

letmaik commented 1 year ago

If it's running a full VS Code server like Codespaces then virtualWorkspaces isn't supposed to be true. Looks like a bug to me on their end. Feel free to raise the issue there and mention this issue.