search

leto / plparrot

Embed Parrot+Rakudo into PostgreSQL
http://pl.parrot.org
Artistic License 2.0
27 stars 5 forks source link

Make PIR procedure source code length configurable, have a sane default and error on invalid input #17

Closed leto closed 14 years ago

leto commented 14 years ago

Currently, stored procedures are only allowed to have 1000 characters maximum, and the source is truncated to 1000 characters, instead of error-ing on procedures that are too long.

What is a reasonable default maximum? This is a compile-time knob.

davidfetter commented 14 years ago

1G is the usual in PostgreSQL

theory commented 14 years ago

Why have a max at all?

theory commented 14 years ago

Fetter explains to me via IRC that by "1G" he means 1GB. ISTM that we should go with whatever limitation is imposed by PostgreSQL and not worry about it. Either way, 1000 characters is far, far to small.

leto commented 14 years ago

I've created a config.h which defines a default maximimum of 64KB. Who is writing subroutines that have a billion characters? In any case, it is easily changed at compile-time.