search

letoams / hash-slinger

GNU General Public License v2.0
50 stars 14 forks source link

python2 to python3 #24

Closed Cherkah closed 4 years ago

Cherkah commented 5 years ago

not an issue all dependencies are python2. does hash-slinger will refresh to python3?

thank for your work

stoecker commented 5 years ago

I started a bit, but had not time to continue. Some things can be changed, so code supports python2 and python3, other things are python3 specific and need a 2/3 switch at the start of the tool.

Patches/Pull requests are welcome.

frankcrawford commented 4 years ago

Are you sure you really want to continue supporting Python2? It will just make the code more complicated and messy if you try and do both at once. Given this project only moves slowly it would be simpler to just draw a line and say the current version is the last Python2, and all going forward will be Python3. I'm happy to submit a PR for the upgrade to Python3.

stoecker commented 4 years ago

That would be fine. openSUSE also already deprecated python2. A complete switch to python3 would be fine. If you do the conversion I happily accept a submission.

letoams commented 4 years ago

That would work for me

Sent from my iPhone

On Oct 24, 2019, at 13:39, Frank Crawford notifications@github.com wrote:

Are you sure you really want to continue supporting Python2? It will just make the code more complicated and messy if you try and do both at once. Given this project only moves slowly it would be simpler to just draw a line and say the current version is the last Python2, and all going forward will be Python3. I'm happy to submit a PR for the upgrade to Python3.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

stoecker commented 4 years ago

Fixed

stoecker commented 4 years ago

I did update the remaining files (with a bit trouble, seems I need to wakeup first :-) for a release on Sunday. I think that should be enough time to find small troubles...