Closed tarjei closed 7 years ago
Reverted. Will look into this when I have more time. Thanks!
Check out the PR I submitted. It's big but it does what I need - and also keeps the original behavior :)
Thanks @tarjei 👍 Will review and merge soon!
:) Please note that I somehow re-added the math-input directory. Was there a special reason why you didn't just add math-input as a dependency?
Sure. It should be a dependency! There are some issues and I have to modify the math-input source code (from ClassJourney/math-input fork with non-mobile support) to make it working with this plugin. Will try to add it as a dependency! :smile:
@letranloc do you think math-input is willing to accept a PR for the changes?
@tarjei haha you can try 😄
How big were the changes?
2017-09-27 4:03 GMT+02:00 Tran-Loc Le notifications@github.com:
@tarjei https://github.com/tarjei haha you can try 😄
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/letranloc/draft-js-katex-plugin/issues/3#issuecomment-332387199, or mute the thread https://github.com/notifications/unsubscribe-auth/AAM5P7GSCDHxpZDFhCb7T4D_I2E6l8TWks5smazzgaJpZM4PY5gS .
--
Tarjei Huse Mobil: 920 63 413
I think (I don't remember exactly) I added import/require for lib/i18n, lib/icu-slim, katex and added css (with imported katex styles)
Thoughs?
Hmm, ok. I'll look into this someday :)
Hi, a problem with the latest release is that it is way bigger than the old release. Would it be possible to have both worlds? I.e. that the user gets the light version first and can choose the heavier version with more help if it is needed?