Assignment 2

[letrungtruc]

@coderschoolreview: please help to review

[hoksilato]

Hi @letrungtruc, nice work with submission :+1:

The goals of this homework are:

• to know how to implement authentication from scratch in Rails with the help of the has_secure_password class method and the brypt gem (while understanding what they do under the hood)
• to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for belongs_to/has_many, using has_many :through and building more advanced queries by chaining where, order, and merge
• to build more complex forms in views that involve multiple models.

Quick review:

• Good work with validations for register and create new message form.
• Clean routes.
• Good use for user partial view.
• Nice checking user is author or recipient when showing message detail.

Small issues:

• Can't logout on Heroku.
• Don't have any ways back to homepage.

Suggestions

Gemfile:

• How can you deploy to Heroku? Because you didn't include rails_12factor gem.

Routes:

• You can limit routes with resources with only keyword, g.e. your sessions_controller didn't need anymore action but new, create, destroy.

Controllers:

• You should check user signed in or not in your messages_controller and friend_request action before doing things. You can use before_action and your helper method current_user for this.

Others

• Should not allow add friend with yourself.

Congrats again on the submission. Everyone has limited time; it's good to see you finished all required functionalities. Let us know if you have any feedback.