Closed dkastl closed 3 months ago
Sorry, I don't understand the linting rule, which makes adding this extra comment line fail. This is just one line that tries to be similar to other comments.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
dc59187
) to head (87a8472
). Report is 34 commits behind head on v0.37.0-next.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The reason for the lint error is a mismatch between the config.sh
file to the .config.sh
file.
*** lint shellcheck ***
*** lint yamllint ***
*** config.sh ***
315d314
< # Must be between 2 and 20 when specified
Error: Process completed with exit code 1.
The config.sh
file has been updated by PR #372 and #377, so update your working branch dkastl:fixes-nodered-instance-number-comment
.
config.sh
file as shown:# Must be between 1 and 20 when specified
With the fix by the PR #375, The NODE_RED_INSTANCE_NUMBER
option can be set to a value between 1 and 20.
To fix a lint error, copy the config.sh
file to the .config.sh
file.
Add the title of this PR into the CHANGELOG.md
file.
Run git push
command again.
Thanks.
Fixed by the PR #385.
Proposed changes
This PR clarifies, that variable
NODE_RED_INSTANCE_NUMBER=
must be between2
and20
or left empty in order to apply the default value of1
.This makes it be inline with the error message: https://github.com/lets-fiware/FIWARE-Big-Bang/blob/main/lets-fiware.sh#L372-L389
This fixes #373 .
Types of changes
What types of changes does your code introduce to the project: Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.v0.37.0-next
branch.Further comments
This is probably the easiest "fix" to prevent users to specify
1
and get an error.