lets-fiware / ngsi-go

The NGSI Go is a command-line interface supporting FIWARE Open APIs for FIWARE developers.
https://ngsi-go.letsfiware.jp/
MIT License
15 stars 5 forks source link

orion should be an option for --brokerType #122

Closed fgalan closed 3 years ago

fgalan commented 3 years ago

Testing with ngsi-go version 0.8.0 if I run:

ngsi broker add --help

I see:

   --brokerType value              orion-ld, scorpio, stellio

Should "orion" been added to this list? Note that orion and orion-ld are not the same piece of software...

fisuda commented 3 years ago

The --brokerType option is for NGSI-LD brokers. It is used with --ngsiType ld. (I'll add this to the documentation) In the case of Orion, it is not needed. You can add an Orion broker (NGSIv2) with the following command.

ngsi broker add --host orion --brokerHost http://localhost:1026/ --ngsiType v2
fgalan commented 3 years ago

Thanks for the feedback!

I agree it would a good idea to specify that --brokerType refers only to NGSI-LD brokers and it is not needed for NGSIv2.

fgalan commented 3 years ago

PR https://github.com/lets-fiware/ngsi-go/pull/124 solves this issue so I'm closing it.