letsar / gap

Flutter widgets for easily adding gaps inside Flex widgets such as Columns and Rows or scrolling views
MIT License
211 stars 20 forks source link

Gap v3.0.0 breaks under Flutter 3.12.0-8.0.pre.21 #16

Closed domesticmouse closed 1 year ago

domesticmouse commented 1 year ago

In attempting to compile https://github.com/flutter/samples/tree/main/next_gen_ui_demo (and by extension https://github.com/flutter/codelabs/tree/main/next-gen-ui) under Flutter master channel, I'm seeing the following failures.

$ flutter run
Connected devices:
macOS (desktop) • macos  • darwin-arm64   • macOS 13.4 22F66 darwin-arm64
Chrome (web)    • chrome • web-javascript • Google Chrome 114.0.5735.133

No wireless devices were found.

[1]: macOS (macos)
[2]: Chrome (chrome)
Please choose one (or "q" to quit): 1
Launching lib/main.dart on macOS in debug mode...
2023-06-22 12:25:01.777 xcodebuild[68777:17538613] DVTCoreDeviceEnabledState: DVTCoreDeviceEnabledState_Disabled set via user default (DVTEnableCoreDevice=disabled)
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:arm64, id:00006000-001250C00C38801E }
{ platform:macOS, arch:x86_64, id:00006000-001250C00C38801E }
../../../../.pub-cache/hosted/pub.dev/gap-3.0.0/lib/src/rendering/gap.dart:43:38: Error: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'.
 - 'RenderObject' is from 'package:flutter/src/rendering/object.dart' ('../../../../flutter/packages/flutter/lib/src/rendering/object.dart').
 - 'AbstractNode' is from 'package:flutter/src/foundation/node.dart' ('../../../../flutter/packages/flutter/lib/src/foundation/node.dart').
    final AbstractNode? parentNode = parent;
                                     ^
../../../../.pub-cache/hosted/pub.dev/gap-3.0.0/lib/src/rendering/gap.dart:45:25: Error: The getter 'direction' isn't defined for the class 'AbstractNode?'.
 - 'AbstractNode' is from 'package:flutter/src/foundation/node.dart' ('../../../../flutter/packages/flutter/lib/src/foundation/node.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'direction'.
      return parentNode.direction;
                        ^^^^^^^^^
Target kernel_snapshot failed: Exception

Command PhaseScriptExecution failed with a nonzero exit code
warning: Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Flutter Assemble' from project 'Runner')
** BUILD FAILED **

Building macOS application...                                           
Exception: Build process failed

I expect this version of Flutter to show up on the beta channel in the coming weeks, and show up in stable in August-ish.

For context, here's flutter doctor output:

$ flutter doctor -v
[✓] Flutter (Channel master, 3.12.0-8.0.pre.21, on macOS 13.4 22F66 darwin-arm64, locale en)
    • Flutter version 3.12.0-8.0.pre.21 on channel master at /Users/brettmorgan/flutter
    • Upstream repository https://github.com/flutter/flutter
    • Framework revision a2739c09a7 (31 minutes ago), 2023-06-22 06:01:18 -0400
    • Engine revision 8cc6d6d5ef
    • Dart version 3.1.0 (build 3.1.0-236.0.dev)
    • DevTools version 2.24.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/brettmorgan/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] VS Code (version 1.79.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.66.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.4 22F66 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 114.0.5735.133

[✓] Network resources
    • All expected network resources are available.

• No issues found!
letsar commented 1 year ago

Thanks, a fix has been published in 3.0.1

yashjoshi007 commented 7 months ago

For older versions use : final AbstractNode? parentNode = parent; -> final RenderObject? parentNode = parent;