search

letsar / gap

Flutter widgets for easily adding gaps inside Flex widgets such as Columns and Rows or scrolling views
MIT License
211 stars 20 forks source link

Add computeDryLayout #5

Closed jamesblasco closed 3 years ago

jamesblasco commented 3 years ago

Hello! In Flutter 1.25, there is a new method in RenderObject called computeDryLayout. It is used to calculate the size of the RenderObject by given constraints without the need to layout it.

image https://flutter.dev/docs/release/breaking-changes/renderbox-dry-layout

As an example here is the implementation for RenderConstrainedBox used for SizedBox.

https://github.com/flutter/flutter/blob/4901744e62f67ad10440725d2c97e84e66ce77f5/packages/flutter/lib/src/rendering/proxy_box.dart#L288-L295

If you need, I would be happy to help with a PR

letsar commented 3 years ago

Hi @jamesblasco ! Thanks for raising this issue :-). I have no bandwidth for the moment so I would be very happy if you could make this PR. The only thing I would need to do then, would be to create a new branch for this, because this change cannot be in the master branch where I want it to be available for the stable branch of Flutter. I also wonder if we can have more than one pre-release in pub.dev, do you if it's possible?

letsar commented 3 years ago

I created the beta branch for this. It would be great if you can make this PR to this branch. Thanks again

jamesblasco commented 3 years ago

I will do that then! Thanks. I think it is possible to publish multiple pre release versions with different names. But we can wait until it reaches beta and add it inside null safety

letsar commented 3 years ago

Added in 2.0