letsar / local_hero

A widget which implicitly launches a hero animation when its position changed within the same route.
MIT License
208 stars 48 forks source link

flutter 2.8 support #7

Closed laiiihz closed 9 months ago

laiiihz commented 2 years ago

this package not working with the latest flutter version.

laiiihz commented 2 years ago

flutter sdk change this api controller.link.leader to controller.link.debugLeader, and does not work in other modes except debug. layer.dart#L2130

muhammadidrees commented 2 years ago

Any update on this?

cchamm commented 2 years ago

Error encounter if building with flutter 2.8

`../flutter/.pub-cache/hosted/pub.dartlang.org/local_hero-0.2.0/lib/src/rendering/layer.dart:54:25: Error: The getter 'leader' isn't defined for the class 'LayerLink'.

cchamm commented 2 years ago

This pull request hide the leader field in the LayerLink class. I am requesting them to revert this change.

kpk-i710 commented 2 years ago

This pull request hide the leader field in the LayerLink class. I am requesting them to revert this change.

I really need this package, I donโ€™t know how to fix it if I copy the package to my project for example from github. To work on the latest version of flutter?

bimsina commented 2 years ago

@kpk-i710 It's working in the master branch of flutter. You can switch to the master branch for now if that's possible.

kpk-i710 commented 2 years ago

@kpk-i710 It's working in the master branch of flutter. You can switch to the master branch for now if that's possible.

thanks for the information, while I'm better at the 2.5 stable version, it also works.

mario202k commented 2 years ago

I could suggest this : https://stackoverflow.com/questions/71468925/how-to-transform-a-widget-by-switching-view But It's not a perfect solution. If someone wants to enhance my code... My best version is not there.

Urvish24 commented 2 years ago

Do we have any update regarding this issue?

laiiihz commented 2 years ago

Do we have any update regarding this issue?

flutter 3.0.x is working now ๐Ÿ˜†

kpk-i710 commented 2 years ago

Do we have any update regarding this issue?

flutter 3.0.x is working now ๐Ÿ˜†

Seriously? Are there any warnings in the console?

laiiihz commented 2 years ago

@kpk-i710 yes its working(more detail: flutter/flutter#92598) but have another warnings. fix: https://github.com/flutter/website/blob/main/src/development/tools/sdk/release-notes/release-notes-3.0.0.md#if-you-see-warnings-about-bindings