letsar / local_hero

A widget which implicitly launches a hero animation when its position changed within the same route.
MIT License
209 stars 48 forks source link

LocalHeroScope needed to use Local Hero #9

Open FrankDomburg opened 2 years ago

FrankDomburg commented 2 years ago

I noticed that I had to add a LocalHeroScope to my app, in order to make everything work.

Does it make sense to integrate that into LocalHeroController? Would make for much simpler implementation right?

Also, made a pull request, so that everything compiles neatly (at least for Android development) without warnings.