letscontrolit / ESPEasy

Easy MultiSensor device based on ESP8266/ESP32
http://www.espeasy.com
Other
3.26k stars 2.2k forks source link

Trailing spaces in unit name should be removed automatically? #2329

Closed hrikken closed 4 years ago

hrikken commented 5 years ago

If I give the unit a name (f.i. the Chip id of the ESP8266) and add accidentally a trailing space, this space should be removed. If not, this space is added to the MQTT publish topic in the rules. This is very annoying.

TD-er commented 5 years ago

What build are you using? This sounds quite familiar to me, like I did change that just a few days ago. So either you're using an "old" build, or I did miss something when fixing that.

hrikken commented 5 years ago

Hi Gijs,

I used the latest: ESPEasy_mega-20190216

Fyi: I’ve added the BME680 plugin

Van: Gijs Noorlander notifications@github.com Verzonden: maandag 18 februari 2019 14:12 Aan: letscontrolit/ESPEasy ESPEasy@noreply.github.com CC: hrikken harry.rikken@rikkenit.nl; Author author@noreply.github.com Onderwerp: Re: [letscontrolit/ESPEasy] Trailing spaces in unit name should be removed automatically? (#2329)

What build are you using? This sounds quite familiar to me, like I did change that just a few days ago. So either you're using an "old" build, or I did miss something when fixing that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/letscontrolit/ESPEasy/issues/2329#issuecomment-464726472 , or mute the thread https://github.com/notifications/unsubscribe-auth/Aq27WMkZCv_pMIyMopYqAOJgBYFTb1mPks5vOqaZgaJpZM4bAz7U . https://github.com/notifications/beacon/Aq27WM_RNz_ELuZt_BKESjXFTNsXNo2Dks5vOqaZgaJpZM4bAz7U.gif

TD-er commented 5 years ago

Should be fixed when #2353 is merged.