Unit Number always gets appended to hostname - Githubissues

letscontrolit / ESPEasy

Easy MultiSensor device based on ESP8266/ESP32

http://www.espeasy.com

Other

3.28k stars 2.22k forks source link

Unit Number always gets appended to hostname #3985

Closed chunter1 closed 1 year ago

chunter1 commented 2 years ago

Checklist

[x] The title of this issue is "to the point" and descriptive.
[x] This issue describes what is happening.
[ ] This issue describes what components are affected (e.g. name of plugin/controller)
[ ] This issue describes how to reproduce it.
[ ] This issue describes when it was introduced (when known) and what version is now showing the problem.

I have...

[x] searched the issue tracker or the forum for a similar issue. (include links when applicable)
[ ] entered a system description using "Copy info to clipboard" on the sysinfo page. (when possible)
[ ] entered the full filename of the used version (e.g. ESP_Easy_mega-20181001_test_ESP8266_4096_VCC.bin )
[ ] given a list of active plugins or controllers when applicable.
[ ] filled out all applicable fields below.

Steps already tried...

[ ] Tried a clean install (empty .bin files are included in the ZIP)
[ ] Tested previous/other build (mention which one already tested)
[ ] Tested on other node to make sure hardware isn't defective.
[ ] Verified if the problem is limited to a single plugin/controller

If you self compile, please state this and PLEASE try to ONLY REPORT ISSUES WITH OFFICIAL BUILDS!

Summarize of the problem/feature request

YOUR TEXT GOES HERE

Expected behavior

YOUR TEXT GOES HERE

Actual behavior

YOUR TEXT GOES HERE

Steps to reproduce

System configuration

Hardware:

ESP Easy version:

ESP Easy settings/screenshots:

Rules or log data

tonhuisman commented 2 years ago

You have unchecked the Append Unit Number to hostname checkbox on the Config page?

chunter1 commented 2 years ago

Yes, exactly this is the issue. It always gets added - and if you check the box it get added even a second time like.... "UNITNAME_12_12"

tonhuisman commented 2 years ago

Where do you see it getting added? (I have an idea, but like to see your exact finding... 😃)

TD-er commented 2 years ago

Just as an example, with a node I just updated to the latest source

Where is it added twice?

TD-er commented 2 years ago

Hmm I do see it is added twice on the MQTT Client ID:

chunter1 commented 2 years ago

I see it in FHEM under the MQTT devices.

TD-er commented 2 years ago

As the default client ID, like in my screenshot?

chunter1 commented 2 years ago

Yes

TD-er commented 2 years ago

Is that the only place?

chunter1 commented 2 years ago

I noticed it only there since i am only using FHEM with MQTT.

TD-er commented 2 years ago

OK, will include it in another fix for MQTT I'm currently working on... The other fix is that if the MQTT broker is unreachable, ESPEasy will try to reconnect too frequently causing 100% load and timeouts, etc.

TD-er commented 2 years ago

Was just looking through small fixes to do and came accross this issue.

The default client ID format is this (highlighted): So can you check by setting it to %sysname% ?

tonhuisman commented 1 year ago

This is a fix I have tested some time ago, and confirmed working, so this can most likely be closed.