P067 Only one channel operative at a time.

8lazo8 commented 2 years ago

Checklist

[x] The title of this issue is "to the point" and descriptive.
[x] This issue describes what is happening.
[x] This issue describes what components are affected (e.g. name of plugin/controller)
[x] This issue describes how to reproduce it.
[x] This issue describes when it was introduced (when known) and what version is now showing the problem.

I have...

[x] searched the issue tracker or the forum for a similar issue. (include links when applicable)
[x] entered a system description using "Copy info to clipboard" on the sysinfo page. (when possible)
[x] entered the full filename of the used version (e.g. ESP_Easy_mega-20181001_test_ESP8266_4096_VCC.bin )
[x] given a list of active plugins or controllers when applicable.
[x] filled out all applicable fields below.

Steps already tried...

[x] Tried a clean install (empty .bin files are included in the ZIP)
[x] Tested previous/other build (mention which one already tested)
[x] Tested on other node to make sure hardware isn't defective.
[x] Verified if the problem is limited to a single plugin/controller

Summarize of the problem/feature request

I have a setup NodeMCU ESP8266 with two HX711 connected. One HX711 has only channel A enabled and it working fine, channel B is off. The other HX711 has a load cell on each channel. The problem is that dual channel mode is not working. If channel A is enabled, channel B displays 0. If I disable channel A then channelb B starts to work fine. When I enable channel A again channel B shows 0 again.

I am using official builds. The actual build I am using is ESP_Easy_mega_20220809_collection_A_ESP8266_4M1M.bin I tried it with a clean install with the build ESP_Easy_mega_20220616_test_A_ESP8266_4M1M.bin with the same result.

I tried to interchange the loadcells, tried them one by one on every channel. Every each works fine until only one channel is enabled.

Also noticed when both channels are enabled, beside the channel B shows 0, channel A shows incorrect numbers now and then.

Expected behavior

To work in dual mode (interleaved mode)

Actual behavior

Only one channel can be used at a time, when both are enabled ony A is producing data.

Steps to reproduce

Add new device HX711
Configure both channels
Check data. Only channel A gives data, B is 0.
Turna channel A off.
Channel B starts to show data.

Hardware: NodeMCU ESP8266 HX711 (green)

ESP Easy version:

Build:⋄ 20116 - Mega System Libraries:⋄ ESP82xx Core 2843a5ac, NONOS SDK 2.2.2-dev(38a443e), LWIP: 2.1.2 PUYA support Git Build:⋄ mega-20220809_57b0c0c Plugin Count:⋄ 79 [Normal] [Collection] [Collection_A] Build Time:⋄ Aug 9 2022 09:42:55 Binary Filename:⋄ ESP_Easy_mega_20220809_collection_A_ESP8266_4M1M Build Platform:⋄ Linux-5.10.102.1-microsoft-standard-WSL2-x86_64-with-glibc2.29 Git HEAD:⋄ mega-20220809_57b0c0c

ESP Easy settings/screenshots:

When both channels enabled:

kép kép kép

When channel A off:

kép kép kép

Rules or log data

tonhuisman commented 1 year ago

The problem here is that this plugin doesn't yet support multiple instances of the plugin being active at the same time, with the result that they are stepping on each others feet (data) 🤕.

I'll see if that can be fixed.

8lazo8 commented 1 year ago

The problem here is that this plugin doesn't yet support multiple instances of the plugin being active at the same time, with the result that they are stepping on each others feet (data) 🤕.

I'll see if that can be fixed.

Not sure about 'only one plugin instance can be active', how do you mean that? I am using now three devices from the same plugin type. I have to use three HX711 for three devices (only chanel one is enabled for each device) and in this way its working stable. The downside is wasting channels of HX711 and GPIOs from the MCU. Does this mean that there are three instances from the same plugin parallel running?

The problem appears when trying to use both channels of one HX711. By the way thank you for looking up this issue.

kép

tonhuisman commented 1 year ago

On further investigation, this plugin does indeed support multiple instances. I have started refactoring it though, as it uses both global and static variables, that we want to avoid as much as possible, as that occupies memory all the time, even when the plugin is not used. I have seen, while working on the code, that switching channels might be somewhat sketchy, but I'll have to do real tests once the hardware I've ordered has arrived (few days).

tonhuisman commented 1 year ago

@8lazo8 How is your Load-cell hardware connected to both channels of the HX711, as I've found a couple of 1, 2 and 4 cell configurations, but they all seem to be on the A channel, and not using the B channel. (NB: Hardware arrived today, so preparing to start testing 😉)

tonhuisman commented 1 year ago

@8lazo8 How is your Load-cell hardware connected to both channels of the HX711,

I have connected 1 load-cell to channel A and another to channel B, and for me it is all working as intended, Also connected a second HX711 but as I have only 2 load-cells currently, it is only measuring some noise. I'll keep it running for some time to see if it is stable.

8lazo8 commented 1 year ago

@8lazo8 How is your Load-cell hardware connected to both channels of the HX711,

I have connected 1 load-cell to channel A and another to channel B, and for me it is all working as intended, Also connected a second HX711 but as I have only 2 load-cells currently, it is only measuring some noise. I'll keep it running for some time to see if it is stable.

I dont have the exact picture of my setup, but I can put in a picture of a similar one.

2cell

The first cell of this type was connected to channel A. A second one from the same type connected to channel B.

The second one's white wire went to B- pin, the green wire to B+ pin.

The red and black was connected in parallel with the first cell's wires.

I tried this with multiply HX711 modules with the same result. The details are in the original post. Data was only accurate and stable if only one channel was enabled at a time, doesnt matter which one. (if I recall correctly if any chanel was enabled was working fine individually, if both channels were enabled, only channel A was providing usuable data. ) I also replaced the cells on the inputs, it didnt change the end result.

tonhuisman commented 1 year ago

I'll install an older build, that doesn't have my refactored code, to compare how that behaves 😊

8lazo8 commented 1 year ago

I'll install an older build, that doesn't have my refactored code, to compare how that behaves 😊

Try the build I used.

tonhuisman commented 1 year ago

Well, just 1 minute of testing, and I can confirm it's not working as intended. So my refactoring does solve the issue.

I'll do some more tests, and push a few more improvements and tests, so it will also work fine on ESP32.

Edit: I broke generating events, so that's 1 thing I have to fix 😸

tonhuisman commented 1 year ago

@8lazo8 Once this Actions run is completed you can download the Binaries.zip file and update your unit for testing. Please report back your findings.

NB: It's all forward and backward compatible, just improvements on the code.

8lazo8 commented 1 year ago

@8lazo8 Once this Actions run is completed you can download the Binaries.zip file and update your unit for testing. Please report back your findings.

NB: It's all forward and backward compatible, just improvements on the code.

Thank you, will do a test.

8lazo8 commented 1 year ago

I updated the binary on the device and it (second channel) seems to work. :)

Unfortunatelly the update got rid of my offset data.

**Update: @tonhuisman the problem seems to be bigger here. The offset data was not touched, I believe it just didnt take account it. I could not set the offset or reset the tare at all, the readings didnt change despite I set 0 offset or something other number.

I reverted to the previous version and the offset and tare was working again.**

tonhuisman commented 1 year ago

I could not set the offset or reset the tare at all, the readings didnt change despite I set 0 offset or something other number.

There was a typo (copy/paste error) in my code that broke applying the Offset/Tare value for channel A. Fix is available after this Actions run is completed.

8lazo8 commented 1 year ago

I could not set the offset or reset the tare at all, the readings didnt change despite I set 0 offset or something other number.

There was a typo (copy/paste error) in my code that broke applying the Offset/Tare value for channel A. Fix is available after this Actions run is completed.

This run seems has failed. Is the collection A binary usuable from it? (if its included in the binary.zip in this case)

tonhuisman commented 1 year ago

Yep, most collection A builds have succeeded, AFAICS, so they are usable 👍

8lazo8 commented 1 year ago

Yep, most collection A builds have succeeded, AFAICS, so they are usable 👍

Updated to this build and now every function I tried seems to work. Thank you and btw happy new year! :)

tonhuisman commented 1 year ago

and btw happy new year! :)

Thanks, happy new year to you too 😉

letscontrolit / ESPEasy