Closed BasvanH closed 1 hour ago
And just to be sure there's nothing else wrong, can you try with 2 plugins included?
Ah found the bug...
In _Plugin_init.cpp line 2105:
constexpr size_t Highest_Plugin_id = DeviceIndex_to_Plugin_id_size > 1 ? DeviceIndex_to_Plugin_id[DeviceIndex_to_Plugin_id_size - 1] : 0;
Should be:
constexpr size_t Highest_Plugin_id = DeviceIndex_to_Plugin_id_size > 0 ? DeviceIndex_to_Plugin_id[DeviceIndex_to_Plugin_id_size - 1] : 0;
Not yet tested... but it looks just like a typical 1-off error :)
I only tested with 0 and 1 plugin enabled. Just enabled two, and this builds successfully.
#define USES_P001 // Switch
#define USES_P002 // ADC
constexpr size_t Highest_Plugin_id = DeviceIndex_to_Plugin_id_size > 0 ? DeviceIndex_to_Plugin_id[DeviceIndex_to_Plugin_id_size - 1] : 0;
Applied this and indeed fixes it.
Thanks for the fast response and fix!
Great! Will merge it :)
Thanks for reporting it.
Describe the bug Building custom_274_ESP8266_4M1M without enabling any plugins goes as expected. When enabling one plugin I get this error during build:
To Reproduce 1) Create a Custom.h from the template 2) Enable one of the plugins 3) Build with custom_274_ESP8266_4M1M
Expected behavior No build errors
Used platform (please complete the following information):
Platform Specifics (when applicable, please complete the following information):
Additional context Did full and partial clean, did not help.
With custom_312_ESP8266_4M1M the error is also there but a bit different: