search

letscontrolit / ESPEasy

Easy MultiSensor device based on ESP8266/ESP32
http://www.espeasy.com
Other
3.26k stars 2.21k forks source link

Simple fix for MH-Z19 B version. #529

Closed TD-er closed 6 years ago

TD-er commented 6 years ago

I added pull request #525 a few days ago and it is marked for version 2.1, which is fine. But there is a only a very small fix needed to get the "B" version of the sensor working in the 2.0 branch. So is it still possible to add this small fix and then later merge my pul request for the 2.1 release cycle?

The small fix is to allow samples with a "S" value of 0 or 64, instead of only 64. Then the users with the "B" version can also use the 2.0 builds without having to code and compile themselves.

It is just a small change in line 295: https://github.com/letscontrolit/ESPEasy/blob/00998a8d3e730412a20f81d4ec8c12ccb1566710/src/_P049_MHZ19.ino#L295

That line should be } else if (s > 0 && s < 64) {

psy0rz commented 6 years ago

ah thats fine indeed. thanks.

psy0rz commented 6 years ago

thanks, i changed it in commit 0dfa98cacc71e68d0c8aea6377e1e428875d064f

psy0rz commented 6 years ago

dont know what happend...cant find the commit nor the change :S

psy0rz commented 6 years ago

well now its changed for real :)