letsdoitworld / World-Cleanup-Day

☀️ World Cleanup Day: App (React Native) & Platform (Node). Join us in building software for a cleaner planet! PRs welcome!
https://www.letsdoitworld.org/
GNU General Public License v3.0
109 stars 45 forks source link

[Admin web] When location is added from GPS coordinates, right-hand map should change it's location #129

Open kadry55 opened 6 years ago

kadry55 commented 6 years ago
  1. LogIn
  2. Map didn't load.
  3. I clicked on Create Trashpoint
  4. Map loaded in my location
  5. I inserted coordinates in Bosnia and Herzegovina (decimal)
  6. Map stayed in my loaction (Estonia)
  7. I added photo from computes, type and amount
  8. I clicked on add trashpoint
  9. Map stayed in my location (Estonia)
  10. I zoomed out to the inserted coordinates place in Bosnia and Herzegovina
  11. Trashpoint appeared twice on screen
  12. I opened the trashpoint to delete one.
  13. Delete button didn't work - after I click on it, nothing happens

Story has 4 issues:

  1. map didn't load - SPEED
  2. map didn't change the place to B&H
  3. Trashpoint was added twice - SPEED
  4. Trashpoint couldn't be deleted - half an hour later, one of the trashpoints was deleted - SPEED
lynxlynxlynx commented 6 years ago

Can't reproduce anything but the title issue.

lynxlynxlynx commented 6 years ago

So, this is a relatively easy fix. Both handleLocationChanged methods need to update the map. The google map library has panTo and fitBounds methods we could use to recenter, but they're currently not exposed in MapView or elsewhere.