search

letsdoitworld / World-Cleanup-Day

☀️ World Cleanup Day: App (React Native) & Platform (Node). Join us in building software for a cleaner planet! PRs welcome!
https://www.letsdoitworld.org/
GNU General Public License v3.0
109 stars 45 forks source link

Typos in i18n source string keys #308

Open krishaamer opened 6 years ago

krishaamer commented 6 years ago

lable_coordinator instead of label_coordinator lable_join_event instead of label_join_event lable_date_and_time instead of label_date_and_time

Also:

Keys label_what_to_bring_with_you and label_what_to_bring are duplicates, one should be removed.

label_share_event and label_share_event_title should have meaningful values, currently contents refer to trashpoints instead of events.

https://github.com/letsdoitworld/World-Cleanup-Day/blob/master/mobile-app/src/i18n/ui-strings.json

Need to check if dev branch uses correct or incorrect keys.

lynxlynxlynx commented 6 years ago

The three are typoed the same way in the react branch. No real damage.

severianremi commented 6 years ago

Thank you @krishaamer! I'll fix this issue today.

lynxlynxlynx commented 6 years ago

Please don't do the renames, as it will invalidate the strings — people have already translated them. It can wait for after release.

KristiinaKerge commented 6 years ago

label_event_created_text there is typo Let"s