letsencrypt / boulder

An ACME-based certificate authority, written in Go.
Mozilla Public License 2.0
5.19k stars 607 forks source link

python3 switch #4322

Closed icing closed 5 years ago

icing commented 5 years ago

Guys, just a heads up: current HEAD no longer runs on MacOS docker as pyhton3 - although installed via homebrew and first in my $PATH, is not selected. The error than manifests in the "import requests" statement failing.

I went back to the commit before and running with it. So, there is no urgency.

Thanks for the excellent work your do,

Stefan

cpu commented 5 years ago

:wave: hi @icing,

Thanks for the bug report!

Are you running Boulder on bare metal or using the docker containers? My expectation is that the Python environment is provided in the boulder-tools image and shouldn't have to be installed on the host machine.

icing commented 5 years ago

@cpu 🥇!

I run "docker-compose up" on the github clone with some yml change do the FAKE_DNS and config-next. Everything else if plain vanilla.

cpu commented 5 years ago

@icing Very interesting! Looking at the description of your problem again it sounds awfully familiar to https://github.com/letsencrypt/boulder/issues/4284 which was fixed initially by https://github.com/letsencrypt/boulder/pull/4285 and I thought addressed more substantially in https://github.com/letsencrypt/boulder/issues/4291 and the Python3 switch :thinking:

We'll dig into this!

cpu commented 5 years ago

I think this isn't specific to MacOS. I'm able to repro with docker-compose up on my Linux host once I pulled yesterday's updated boulder-tools images.

boulder_1    | Traceback (most recent call last):
boulder_1    |   File "/go/src/github.com/letsencrypt/boulder/start.py", line 17, in <module>
boulder_1    |     import startservers
boulder_1    |   File "./test/startservers.py", line 11, in <module>
boulder_1    |     from helpers import waitport
boulder_1    |   File "./test/helpers.py", line 8, in <module>
boulder_1    |     import requests
boulder_1    | ImportError: No module named requests
boulder_boulder_1 exited with code 1