va: reduce duplication in "Validation result" log message

letsencrypt / boulder

An ACME-based certificate authority, written in Go.

Mozilla Public License 2.0

5.09k stars 595 forks source link

Open jsha opened 2 weeks ago

jsha commented 2 weeks ago

When we log a validation result with an error, it shows up three places:

We log the updated challenge object, which includes the error
We log the error at the top level of the JSON object
We log the internal error

We should fix this by:
- Not logging the updated challenge object
- Logging the internal error only if it differs from the external error (modulo the prefix of the error type)

mcpherrinm commented 2 weeks ago

One error that has caused confusion for users is errors of the form

dns :: no valid A records found for example.com; no valid AAAA records found for example.com

I haven't looked at how that's generated, but could we collapse those errors to no valid A or AAAA records found for example.com as a special-case?