ratelimits: Add a feature-flag which makes key-value implementation authoritative

letsencrypt / boulder

An ACME-based certificate authority, written in Go.

Mozilla Public License 2.0

5.16k stars 605 forks source link

ratelimits: Add a feature-flag which makes key-value implementation authoritative #7666

Closed beautifulentropy closed 1 month ago

beautifulentropy commented 1 month ago

Add feature flag UseKvLimitsForNewOrder
Add feature flag UseKvLimitsForNewAccount
Flush all Redis shards before running integration or unit tests, this avoids false positives between local testing runs

Fixes #7664 Blocked by #7676

github-actions[bot] commented 1 month ago

@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

github-actions[bot] commented 1 month ago

@beautifulentropy, this PR adds one or more new feature flags: UseKvLimitsForNewAccount,UseKvLimitsForNewOrder. As such, this PR must be accompanied by a review of the Let's Encrypt CP/CPS to ensure that our behavior both before and after this flag is flipped is compliant with that document.

Please conduct such a review, then add your findings to the PR description in a paragraph beginning with "CPS Compliance Review:".

beautifulentropy commented 1 month ago

Working through the deployment tickets for this change today.