woodpecker: rename log "start" to "minEntry"

letsencrypt / ct-woodpecker

A tool to monitor a certificate transparency log for operational problems

Mozilla Public License 2.0

182 stars 19 forks source link

woodpecker: rename log "start" to "minEntry" #109

Closed cpu closed 4 years ago

cpu commented 4 years ago

The Log's "start" configuration parameter in the LogConfig struct was confusing. Renaming it to "minEntry" and updating the Godoc will help hopefully help clarify the purpose.

Resolves https://github.com/letsencrypt/ct-woodpecker/issues/108

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 998

2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.243%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
woodpecker/woodpecker.go	2	3	66.67%
<!--	Total:	2	3	66.67%	-->

Totals
Change from base Build 913:	0.0%
Covered Lines:	860
Relevant Lines:	1242

💛 - Coveralls

pgporada commented 4 years ago

Thanks team, this clarification is really helpful.