search

letsencrypt / ct-woodpecker

A tool to monitor a certificate transparency log for operational problems
Mozilla Public License 2.0
182 stars 19 forks source link

Migrate to transparency-dev/merkle #121

Closed pav-kv closed 2 years ago

pav-kv commented 2 years ago

Hi team,

I observe you are using a mix of merkle packages:

We are in the process of decommissioning the merkle package from Trillian, as all our code (including Trillian itself) is now using transparency-dev/merkle. The new repository is well maintained, and we are also going to document some best practices on Merkle tree implementations.

Consider migrating your code fully to transparency-dev/merkle. Happy to help if you have questions on how to do it.

Thank you.

jsha commented 2 years ago

Thanks! We'll make the switch.

aarongable commented 2 years ago

It appears that the version of Trillian which now uses transparency-dev/merkle has not been tagged and released.

This causes problems, particularly in places like here, where Trillian's data structure has been updated to contain a transparency-dev/merkle/compact.NodeID, but the version of Trillian which has been released (and which ct-woodpecker therefore relies on) still uses the internal type. This leads to issues like:

image

Please tag a new Trillian release so that we can update to that version and smoothly make this transition.

pav-kv commented 2 years ago

Thanks for flagging this. We were planing a release anyway, so it will be fixed soon.