search

letsencrypt / ct-woodpecker

A tool to monitor a certificate transparency log for operational problems
Mozilla Public License 2.0
182 stars 19 forks source link

Update to use transparency-dev/merkle library #122

Closed aarongable closed 2 years ago

aarongable commented 2 years ago

Update the few places we still used github.com/google/trillian/merkle types to instead use the corresponding github.com/transparency-dev/merkle types.

In order to do this, update the google/trillian dependency to v1.4.1. This brings in a number of other transitive dependency updates as well.

Fixes #121

jsha commented 2 years ago

Ah, just noticed the tests are failing:

Error: monitor/sth_fetcher.go:130:21: undefined: merkle.NewLogVerifier
jsha commented 2 years ago

I noticed you included an update to .golangci.yml to bring it in line with what Boulder does. That looks good, but any idea why that was necessary to pass tests? If the current .golangci.yml was causing failures, I would have expected to see that in other recent PRs.

aarongable commented 2 years ago

It's because I'd introduced two unnecessary conversions! Unfortunately I ran into the same thing as you, where the output of the linter was no help at showing me where the lints were coming from.

I still think bringing the set of lints we run in line with Boulder is a good thing, but I've also uploaded a new patchset with the unnecessary conversions removed and the "unconvert" linter re-enabled.