coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 242
- 142 of 242 (58.68%) changed or added relevant lines in 4 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-2.9%) to 67.054%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| monitor/cert_submitter.go | 1 | 17 | 5.88% | ||
| monitor/inclusion_checker.go | 99 | 117 | 84.62% | ||
| storage/storage.go | 38 | 66 | 57.58% | ||
| monitor/monitor.go | 4 | 42 | 9.52% | ||
| <!-- | Total: | 142 | 242 | 58.68% | --> |
| Totals | |
|---|---|
| Change from base Build 213: | -2.9% |
| Covered Lines: | 635 |
| Relevant Lines: | 947 |
cpu
The integration tests for this have taken me about 1000% longer than expected so I'm just going to throw this up now to get feedback on the actually important parts while I hack away at getting integration testing working. I'm still not super familiar with this codebase so there is a 100% chance I've missed something obvious I'm supposed to be doing.
For integration testing I've been slowly turning cttestsrv into a gross in-memory log and it's a bit painful. One option is to ignore making the things returned from get-entries match what is returned from get-sth, which for now will be fine but once we start wanting to do things like #37 (which now that I think about it will almost definitely have some overlap in changes in order to properly do integration testing... @cpu how are you planning on doing that?) it'll need to be fixed.