letsencrypt / ct-woodpecker

A tool to monitor a certificate transparency log for operational problems
Mozilla Public License 2.0
182 stars 19 forks source link

Go module/1.11.x support, vendored deps, cttestsrv api fixes. #74

Closed cpu closed 5 years ago

cpu commented 5 years ago

Resolves https://github.com/letsencrypt/ct-woodpecker/issues/72 and https://github.com/letsencrypt/ct-woodpecker/issues/73 and fixes CI.

[0]: Notably this pins Trillian to d0c8d5f - the tip of master at the time of writing. We're using changes that aren't in the latest v1.2.1 tag. Similarly, Trillian at tip of master requires us to pin golang/protobuf at 1d3f30b - the tip of master for that project at the time of writing. Trillian is using changes in this project that aren't in the latest v1.2.0 tag.

[1]: Errcheck doesn't work with Go modules and our vendored deps. Adding it back is blocked on https://github.com/kisielk/errcheck/issues/155 Personally I think the stability improvements of vendored dependencies merits removing errcheck from Travis and the cron builds. We do still get errcheck coverage per-PR with GolangCI.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 484


Totals Coverage Status
Change from base Build 365: 0.3%
Covered Lines: 769
Relevant Lines: 1139

💛 - Coveralls