letsencrypt / website

Let's Encrypt Website and Documentation
https://letsencrypt.org
Mozilla Public License 2.0
841 stars 573 forks source link

Rust clients not appearing on client options page #1699

Closed djc closed 2 months ago

djc commented 2 months ago

When looking at https://letsencrypt.org/docs/client-options/, the Rust section is empty:

Screenshot 2024-06-29 at 12 44 35

When looking at the data/clients.json file that's referenced near the bottom of the page, I see 4 Rust projects:

Not sure why these aren't appearing on the rendered page?

bdaehlie commented 2 months ago

There are two Rust lists - one is applications, the other is libraries. What you took a screenshot of is the libraries section.

When I view that page, I see two clients listed in the applications section and the library section is blank, same as your screenshot.

The reason a number of Rust entries don't show up is that they don't have the acme_v2 field set to True, which is required in order to display, as you can see here:

layouts/shortcodes/clients.html

I will work on a PR to remove anything that doesn't include acme v2 support and get rid of the field altogether, as we don't need it any more.

bdaehlie commented 2 months ago

I fixed the issues in #1700 , got rid of any ACMEv1 clients and removed the v2 tagging we don't need any more which is what made this confusing for you.

Now if we want to fix up the Rust list(s) we just have to add a good list of Rust clients.

djc commented 2 months ago

Thanks! I opened #1701.

(Feels to me like the page might make more sense transposed -- language axis first, then the projects vs libraries axis. But maybe for "Projects" the language axis isn't as important?)