letsfindaway / OpenBoard

I'm using this fork to contribute features and fixes to the upstream project. In order to create good pull requests, I'm rebasing my feature branches, squashing and reordering commits, etc. If you fork this repository be aware that my development branches may rewrite history without prior notice.
http://openboard.ch/
GNU General Public License v3.0
9 stars 0 forks source link

Duplicate local copy #106

Closed letsfindaway closed 2 years ago

letsfindaway commented 2 years ago

To solve issue https://github.com/OpenBoard-org/OpenBoard/issues/671, problem 1 I analyzed the program flow when dropping an object on the board:

I think that the UBDownloadManager should consider where to place the files and whether copy is needed at all. As everything is persisted later, the download manager should probably

The problematic code is probably here: https://github.com/letsfindaway/OpenBoard/blob/fa9efeb8179e693cd7e6e6dcffe828e90c408303/src/board/UBBoardController.cpp#L1085-L1120 For local files we should always call downloadFinished and never copy the file here, as the persistence is managed there.

letsfindaway commented 2 years ago

done