A `target="_blank"` link won't open in a widget

[kaamui]

Found by the test team. A target=_blank link won't open after a page has been embed in a widget.

I think it's potentially systematic, as long as a link is supposed to open in a new tab, but I wonder how we could intercept it to ignore blank attribute.

[letsfindaway]

Interception works probably by overwriting createWindow in the UBWebEngineView. In the Browser, this is already done in WebView. The widgets use a different view, and here this function is currently not reimplemented. However I'm not sure whether we could return this from here. A first test created a SIGSEGV when trying to do this.

According to https://doc.qt.io/qt-6/qwebenginepage.html#createWindow a newWindowRequested() signal is emitted when we don't reimplement this function. That would be an option, however only from Qt 6.2 upward.

I will try to find a solution!

[letsfindaway]

The following overload of UBWebEngineView::createWindow works for me:

QWebEngineView *UBWebEngineView::createWindow(QWebEnginePage::WebWindowType type)
{
    if (type == QWebEnginePage::WebBrowserTab) {
        // create a throwaway view to get the URL
        QWebEngineView* view = new QWebEngineView();

        connect(view, &QWebEngineView::urlChanged, this, [this,view](const QUrl& url){
            // load URL in current view and delete temporary view
            load(url);
            view->deleteLater();
        });

        return view;
    }

    return nullptr;
}

[letsfindaway]

closed as PR was merged