search

letsfindaway / OpenBoard

I'm using this fork to contribute features and fixes to the upstream project. In order to create good pull requests, I'm rebasing my feature branches, squashing and reordering commits, etc. If you fork this repository be aware that my development branches may rewrite history without prior notice.
http://openboard.ch/
GNU General Public License v3.0
9 stars 0 forks source link

Feedback of the camera widget #144

Open kaamui opened 1 year ago

kaamui commented 1 year ago

Hi,

As I am abusing your time on some of the issues I am encountering, I would like to counter-balance this by giving you some positive feedback about the camera widget !

Huge success ! In fact, the only feedback I got is that teachers want more features about it :)

The main feedback is that teachers would like to have the ability to flip the image horizontally or vertically. One of them also asked me if it could be possible to record some clips with it, but I don't know it it would be feasible and I didn't report it to the team, so don't consider it for now.

One of the many cool things you brought to OpenBoard ! Thank you !

letsfindaway commented 1 year ago

I think flipping is just another transformation. Of course possible, but not in one day. So let's put it on the list.

Same with recording. There was also a user request to record sound, so this might even be combined. I know there are sound and video recorder web applications, so it is possible. But I haven't looked into the complexity and also don't know whether a server is necessary in the background to do the encoding or whether everything can just run locally.

kaamui commented 1 year ago

Another aspect to consider is that transformations can also be applied on QGraphicsItems, so it may be already possible to simply enable the "flip-able" flag for the Camera Widget, if possible.

I'll try to take some time for this idea.

letsfindaway commented 1 year ago

Another aspect to consider is that transformations can also be applied on QGraphicsItems, so it may be already possible to simply enable the "flip-able" flag for the Camera Widget, if possible.

That's an idea, but please be aware that this would not affect the generated snapshot. The snapshot is not generated by making a screenshot of the widget, but by transforming and encoding the camera image in JavaScript. See https://github.com/letsfindaway/OpenBoard/blob/3251cc13c7287380c1157cfd20abb0d9b247cd2b/resources/library/applications/Camera.wgt/js/camera.js#L173-L243 for the function taking the snapshot.

The live image is rotated here: https://github.com/letsfindaway/OpenBoard/blob/3251cc13c7287380c1157cfd20abb0d9b247cd2b/resources/library/applications/Camera.wgt/js/camera.js#L255 and I think it would be easy to add a flipping transformation here.

I'll try to take some time for this idea.