[Bug] Very small chance for crash while terminating

letsfindaway / OpenBoard

I'm using this fork to contribute features and fixes to the upstream project. In order to create good pull requests, I'm rebasing my feature branches, squashing and reordering commits, etc. If you fork this repository be aware that my development branches may rewrite history without prior notice.

http://openboard.ch/

GNU General Public License v3.0

9 stars 0 forks source link

[Bug] Very small chance for crash while terminating #191

Closed letsfindaway closed 3 weeks ago

letsfindaway commented 1 month ago

Describe the bug

If the deferred loading loop for a scene is still working while the application is already about to be closed, A crash could occur, because the resources needed to load the scene are no longer available.

To Reproduce

Only theory, never occurred, not reproduced.

Additional resources

I propose to add a global flag isClosing to the UBApplication and to check this flag in the loading loop.

letsfindaway commented 1 month ago

I found a way to reproduce:

Open a document with very heavy scenes. I was using the "Python" test document.
Rapidly switch pages e.g. using the arrow right key.
While switching pages terminate the application. It is important that background loading of the next scenes is still in progress when you terminate it.
OpenBoard crashes while terminating.

letsfindaway commented 3 weeks ago

fixed, PR was merged