Code quality improvements

letsfindaway / OpenBoard

I'm using this fork to contribute features and fixes to the upstream project. In order to create good pull requests, I'm rebasing my feature branches, squashing and reordering commits, etc. If you fork this repository be aware that my development branches may rewrite history without prior notice.

GNU General Public License v3.0

9 stars 0 forks source link

Currently there are a lot of warnings when compiling OpenBoard. In order to increase code quality we should aim to have no warnings even with -Wpedantic switched on.

I have seen in other projects that avoiding any warnings is not only a cosmetic change, but can also help to detect real problems.

See also #13.

List of this and other points:

[ ] Avoid compile warnings.
[ ] I would also like to look over parameter passing. Which functions can be const? Which parameters can be const&?
[ ] Remove copy constructor and assignment operator from classes not meant to be copied.
[ ] Check and harmonize usage of virtual and override.
[ ] Find and remove/update/change remainders of former features, which are now obsolete.

Compile warnings

Unused parameter

Add Q_UNUSED in

UBValidator::validate
UBDocumentController::focusChanged.
UBGraphicsTextItem::dragMoveEvent

Remove unused 3-parameter-constructor in UBThumbnailPixmap.h.

Remove unused UBDocumentTreeView::acceptableAction in UBDocumentController.

Remove unused UBDocumentController::documentSceneChanged.

Remove unused UBBoardController::documentSceneChanged.

Unused variable

Remove unused variables.

letsfindaway / OpenBoard