letsgamedev / Suffragium

A game developed in a democratic cycle.

GNU Affero General Public License v3.0

51 stars 21 forks source link

Add Closing conditions for pull requests #58

Closed letsgamedev closed 2 years ago

letsgamedev commented 2 years ago

Description

Habe einige Bedingungen hinzugefügt um das schließen von Pullrequests zu ermöglichen um so einen besseren Überblick gewährleisten zu können.

Type of change

[ ] Bug fix (non breaking change that fixes an issue)
[x] New feature (non breaking change that adds functionality)
[ ] Tooling (non breaking change that adds functionality to the workflow)
[ ] Breaking change (fix or feature that causes existing functionality to not work as expected)

b7g commented 2 years ago

It is not stated what happens to pull request older then 30 days that were in draft mode (allowance 60 days) and then reopened (allowance 30 days). The intent is not to delete them, right?

Numenter commented 2 years ago

Maybe look at the last commit date and not at the creation date and just close inactive PRs/drafts

b7g commented 2 years ago

I can predict Tom might want to easily see the PRs that can be closed in the overview, without going into every PR. There is a search filter (the bar on top of the PRs) that can be used for that:

is:pr is:open updated:<2022-05-30

this would display only open PRs that had their last commit before the 30 May 2022

Numenter commented 2 years ago

This would speed up the merge validation process. #59

RedstoneMedia commented 2 years ago

Maybe adding a clause that automatically closes PRs if they reach a certain dislike ratio (Maybe 80% ?) after a shorter number of days (Maybe 3 ?) would also be a good idea.

Numenter commented 2 years ago

Folks not only give dislikes because they don't like the PR. They dislike if the PR has flaws that they want to be fixed. Its on the creator to consider, if he wants to edit the PR or to close it. The forced closing is just to clean up after abandoned PRs. Thats how i see it :P.

letsgamedev commented 2 years ago

Ich habe den Vorschlag von Numenter angenommen dass nun der last commit entscheidend ist für das Schließungskriterium. Sollte es also ein PR nicht schaffen innerhalb von 20 Tagen (nach seinem letzten commit, achtung die Gefahr des künstlichen "Am Leben Haltens" ist gegeben durch Mini-commits) durchzusetzen, der PR geschlossen wird.