letsgamedev / Suffragium

A game developed in a democratic cycle.
GNU Affero General Public License v3.0
51 stars 21 forks source link

added new game: Suffro Mania - 5 min long Mega Man like game #73

Closed YukkiTimmy closed 2 years ago

YukkiTimmy commented 2 years ago

Description

Added a new game called "Suffro Mania". It's a 5 min long Megaman like highscore hunting game. Your goal is to kill the boss at the end of the stage with the highest score possible.

grafik

grafik

Please describe the changes you made to the codebase/project files here. Include all relevant context for the changes and list all new dependencies. If your change has visual implications on the project, please provide screenshots or animated GIFs of the changes.

Related to # (issue)

Type of change

Environment

Please describe your environment and remove nonapplicable environment information from this section.

Testing

Please describe the testing you performed on the codebase/project files here and how other users can reproduce your results.

Checklist

Joshix-1 commented 2 years ago
  1. Please respect case when loading scenes. Use everywhere the same case. Case-insensitive loading is bad and doesn't work on every platform. (change main.tscn in game.cfg to Main.tscn)
  2. Did you make all these assets on your own?
  3. please look at the errors in the Debugger. There are too many new ones
  4. make sure to use tools/run_gdtoolkit.py with gdtoolkit to lint and format your changes
RedstoneMedia commented 2 years ago

https://opengameart.org/content/space-war-man-platform-shmup-set

sus

I don't see a License or proper attribution. The sprites are licensed under OGA-BY 3.0, which require attribution and the license to be present. YOU CANNOT SIMPLY COPY SOMEONE's WORK AND DON'T GIVE ATTRIBUTION.

YukkiTimmy commented 2 years ago

https://opengameart.org/content/space-war-man-platform-shmup-set

sus

I don't see a License or proper attribution. The sprites are licensed under OGA-BY 3.0, which require attribution and the license to be present. YOU CANNOT SIMPLY COPY SOMEONE's WORK AND DON'T GIVE ATTRIBUTION.

I know that I can't "SIMPLY COPY SOMEONE's WORK ". If you take a look into the Credits, I named all the authors I used the Opensource Art from.

But I have to admit that i didn't read every paragraph of the text, so I now changed the credit to "Space War Man by Emcee Flesher on opengameart.org", as the author said.

YukkiTimmy commented 2 years ago
  1. thank you didn't see that!
  2. Nope, see the comment below. Like I already said, I gave credit to every author I used the art from.
  3. Wanted to fix them later, but did it now!
  4. I will totaly do that!

Thank you for your feedback.

RedstoneMedia commented 2 years ago

Again. You did not include the OGA-BY 3.0 License. It needs to be present as a file in the repository (Just like our LICENSE.md does too). Also, the credits for the sprites and music are not easily accessible. They are only shown at the very end, when you manage to beat the game (which is why I couldn't find them at first).

Something else: You might want to consider using onready vars more in order to avoid spamming get_parent().get_parent() or get_parent().get_node() (and other methods of navigating the node tree) everywhere. Generally, the rule is : If you need a node more than once, add a private variable for it.

Otherwise, the game ain't half bad (although the giant Main.tscn is killing me a little, but whatever). Creating such a large map probably takes a lot of time.