Update Contributing.md

[Joshix-1]

Require successful checks for merging and make conditions a little bit stricter. No PR with only one upvote and failing checks should be merged after 74h

Type of change

• Updated merge conditions

Checklist

• The project compiles and runs correctly

[ASecondGuy]

I don't like the wording. Maybe something like this?

All must be true:

• No checks are failing
• upvotes - downvotes > 2
• 75% positive votes
• One must be true:
  • Last commit is 24h or older and has more than 10 votes
  • Last commit is 72h or older

[Joshix-1]

I disagree, I think that is worse

[Numenter]

"No checks are failing"

We should implement the Branch protection rules https://github.com/letsgamedev/Suffragium/issues/44 for that. ( Require status checks to pass before merging ) Didn't had the motivation to create a PR for it. Maybe someone else wants to do it.

"upvotes - downvotes > 2"

Looks like a 'min vote of 3' to me.

[Joshix-1]

We should implement the Branch protection rules https://github.com/letsgamedev/Suffragium/issues/44 for that.

Agree, but writing it down is still a good idea. As that's then for everyone visible a rule.

Looks like a 'min vote of 3' to me.

Yes, but better (I think). With a downvote you then need at least 4 upvotes.

[Numenter]

I hate to say it. Suffragium is in a constant decline. Stricter rules don't help and they could hinder any progress in the future.

Yes, but better (I think). With a downvote you then need at least 4 upvotes.

And now you need 3 upvotes (3up 1down). I thought 75 hours was enough time to vote. If you don't vote, you don't count. If a PR goes through because nobody participated, who cares. Clearly nobody.

I'm withholding my vote for this PR, but it's clear how I stand.

[RedstoneMedia]

I agree. A lot of PRs are struggling to even get one or two thumbs up, just because there is so little activity. Making the rules stricter now will accelerate the decline of this project, because there are even longer wait times and thus less activity.

[RedstoneMedia]

I would remove the requirement, where the creator can not vote on his own PR. This forces other users to look at the new PRs every couple of days, if they don't like it they just give it a dislike. This extends the lifetime of the project and could even rejuvenate it, once everyone of the original voters looses interest and there is just one person left.

[Joshix-1]

I think a PR should need at least one upvote of another person.