letsgamedev / Suffragium

A game developed in a democratic cycle.

GNU Affero General Public License v3.0

51 stars 21 forks source link

Pixel side scroller traps #86

Closed l-seidl closed 1 year ago

l-seidl commented 1 year ago

Description

This PR adds spike trap objects and sounds to the pixel-side-scroller game.

The sounds were made with jsfxr (so they are free to use)
Also added a level to introduce the traps

spikes

Type of change

[ ] Bug fix (non breaking change that fixes an issue)
[x] New feature (non breaking change that adds functionality)
[ ] Tooling (non breaking change that adds functionality to the workflow)
[ ] Breaking change (fix or feature that causes existing functionality to not work as expected)

Checklist

[x] My code follows the general style guidelines of the project
[x] I have perfomed a self-review of my code
[x] I have commented my code, particulary where it is unclear
[x] My changes generate no new warnings or errors
[x] The project compiles and runs correctly

MarioLiebisch commented 1 year ago

Just as a minor note/suggestion: Don't describe your commit using pr update. Write what you changed, even if it's just 2-3 words, like Updated misleading naming or whatever, so people also instantly see what a commit tries to do. They can then later be squashed (so will disappear).