letsgamedev / Suffragium

A game developed in a democratic cycle.

GNU Affero General Public License v3.0

51 stars 21 forks source link

Pixel Side Scroller: Improve pawn modularity #90

Closed Numenter closed 1 year ago

Numenter commented 1 year ago

Description

Improved modularity of pawn (movement and input modules)

Additionally:

added more jump inputs
improved and moved out_of_bound logic into map_manager

Type of change

[x] Bug fix (non breaking change that fixes an issue)

Testing

Played Pixel Side Scroller a few times.

RedstoneMedia commented 1 year ago

Note that #87 will probably get merged first. This will cause merge conflicts

MarioLiebisch commented 1 year ago

Does this really improve modularity? I understand the idea, making pawn.input flexible/replaceable, but not sure it wouldn't be better with some signals, if one wants to decouple things?

Numenter commented 1 year ago

Yes, it's an improvement. “Decouple things” in the sense of disable abilities, like move or jump? I designed the pawn to always have a movement and input module (in my head). I'm not seeing the point for signals at this point, but hey maybe an example will open my eyes.

MarioLiebisch commented 1 year ago

Can try, if I find the time, but I guess it's definitely improving the dependencies for now.🙂