letsgamedev / Suffragium

A game developed in a democratic cycle.

GNU Affero General Public License v3.0

51 stars 21 forks source link

Godot 4.1 conversion #95

Open b7g opened 10 months ago

b7g commented 10 months ago

Description

Converted the project to the Godot 4.1 version (4.1.2) This is a work in progress, open for participation. In it's current state it breaks all games, but snake.

Checklist

[ ] My code follows the general style guidelines of the project
[ ] I have perfomed a self-review of my code
[ ] I have commented my code, particulary where it is unclear
[ ] My changes generate no new warnings or errors
[ ] The project compiles and runs correctly

Joshix-1 commented 10 months ago

you need to update the Godot version in the Earthfile

ASecondGuy commented 10 months ago

Not sure if we should port to Godot 4 but if we do now would be the best moment when nobody is working on anything else.

b7g commented 10 months ago

Well, that did not work out. Who can fix the build/lint workflows?

Joshix-1 commented 10 months ago

I don't know how to fix the build. The error message is weird. I don't know earthfile stuff

Joshix-1 commented 10 months ago

changed the build completly without earthly, that seems to work: https://github.com/letsgamedev/Suffragium/commit/6275bfe3d5e1c0c2425e9c8b33f31567e678ca9c

BjoernAkAManf commented 10 months ago

Related statement missing

Which is stated quite clearly in the logs. Annoying yes, but given thhat it kept workiing till now is quite nice.

Don't have a preference either way though :)

b7g commented 10 months ago

Now that looks good, thanks.