search

lettier / gifcurry

😎 The open-source, Haskell-built video editor for GIF makers.
https://lettier.github.io/gifcurry
BSD 3-Clause "New" or "Revised" License
1.36k stars 56 forks source link

Font size setting effects only the top line #12

Closed jlntrt closed 5 years ago

jlntrt commented 7 years ago

Hey, first thanks for this handy tool. very cool! :+1:

One bug I found recently: in the current version (2.1.1.0), the size of the font settings effects only the top line, not the bottom line.

lettier commented 7 years ago

Hello @jtauert. I am glad you like it. :+1:

The font size information found on the font choice dialog is not used. I will look into getting this removed as to not cause confusion.

During the text overlay phase, the font size is dynamically calculated to fit in the lower and upper boxes designated for text.

To alter the size of either the top or bottom text, add more or less characters (spaces are allowed).

For example, assume the space character is s:

upper

flower

Credit: Big Buck Bunny

jlntrt commented 7 years ago

Hey @lettier, thanks for your reply.

Okay, get it. I thought I can change the font size for both boxes by setting the size in the font setting dialog.

And by the way: thanks for sharing your tool as open source. :)

skerit commented 7 years ago

It would be more useful if the font settings WERE used, though. The font is too small most of the time, even when there's plenty of room to double the size :/

lettier commented 6 years ago

Hello @jlntrt and @skerit,

Gifcurry now supports dynamic text. The end result font size selection is fully controllable.

gifcurry-font-size

You can try it out in the 4.0.0.0 pre-release.

:+1: