search

lettier / movie-monad

:tv: A free and simple to use video player made with Haskell.
https://lettier.github.io/movie-monad
BSD 3-Clause "New" or "Revised" License
420 stars 24 forks source link

Time seek wraps around beginning and ending #11

Closed airabinovich closed 6 years ago

airabinovich commented 6 years ago

It's awesome you included the feature I asked for, thanks! But to help improving your video player I want to report this issue

Given I'm playing a video And time is at 0:05 When I press left arrow to go back in time Then the time goes to the near-end of the video

Same behavior is shown when I go to forward near the end, I go back to the near-beginning

lettier commented 6 years ago

Hello @airabinovich,

Yes this is the intended effect.

video-seek-wrap

Say the video is Y time long and going backwards once would put it at time 00:00 - X then the slider position is put at Y - X.

Would you rather it truncate to 00:00?

:+1:

airabinovich commented 6 years ago

Hi @lettier,

As I see it, you can accidentially jump to the near-end of a video and watch some part you shouldn't have watched yet (spoilers) I'd truncate the time seek at 00:00 and at Yas well. (Being Y the video length)

On another matter, I believe the time seek step is a portion of Y. I'd rather make it a fixed length (10 seconds I think is a good span)

lettier commented 6 years ago

Hello @airabinovich,

I changed the functionality to now stop at the beginning when seeking left and to stop at the end when seeking right.

I also reduced the step size for a more granular experience.

You can try out the pre-release here.

:+1:

airabinovich commented 6 years ago

It looks good to me now, great!