Review and Restructure Methods in New Flow ABC Class

lettucecfd / lettuce

Computational Fluid Dynamics based on PyTorch and the Lattice Boltzmann Method

MIT License

203 stars 39 forks source link

Review and Restructure Methods in New Flow ABC Class #169

Open McBs opened 1 month ago

McBs commented 1 month ago

All methods from the old Lattice class have been transferred to the new Flow ABC class. We need to review and possibly restructure these methods to ensure they are logically organized and adhere to our coding standards.

Edit by @PhiSpel:

[ ] When you're done with this, do make sure to reactivate test_collision_fixpoint_2x_MRT

PhiSpel commented 1 month ago

Some, such as lattice.einsum, should be removed. See also https://github.com/lettucecfd/lettuce/issues/111

Edit: Done in #241

PhiSpel commented 3 weeks ago

lattice methods such as rho(f), u(f), entropy(f), etc. could be stored separately so that they can be accessed by tests without creating a Flow object. These methods do not require Flow-specific attributes, except sometimes the stencil weights.

[ ] When you're done with this, do make sure to reactivate test_collision_fixpoint_2x_MRT