Open ivanmem opened 2 months ago
Thanks for this suggestion.
The first issue of this repo was also "support generics".
You can't see The original issue because it is deleted (I think the issuer did)
I reject that pull request because of some reasons. I cant remember all of that. But the core reason was...
I replyed the previous one with the benchmark test (you can use that benchmark code in the branch rv/1) and detailed explanation.
Unfortunately, I'm in vacation.
So I can't review your code now.
When i return to my home, I will resolve this issue firstly.
If you show me the benchmark result, it will be easy and quick task.
You may test with my bench code in branch rv/1.
Or you can use your benchmark code.
I didn't change the implementation. Here only generics have been added. In theory, performance should not have changed, nor would complexity.
Okay, I see. I'll check it out after my vacation, just give me a few days.
It was a PR, not an issue, I was mistaken. you can check this #1
Maybe the inclusion of the isSubtype function in this PR is causing a slowdown in performance. I'm uncertain of the necessity of invoking this function since the code appears to function properly without it. It's probable that I'm overlooking some minor details.
I would like to see generic support added to the library. Here is an example implementation:
Tests: