leukbaars / DreamUV

DreamUV - 3D viewport UV editing tools for Blender
1.35k stars 58 forks source link

Version 0.9.1 / Blender 3.0 - Error when unwrapping mesh with triangles in #27

Open JClarkRichardson opened 2 years ago

JClarkRichardson commented 2 years ago

Hello! I've been using this plugin for a while and I really love it.

Recently, I've noticed an issue where I get an error if I try to unwrap meshes that have triangles in them instead of quads. For instance if I take a cube and bevel its edges, there will be triangles at each corner, and if I try to unwrap it with DreamUV, I get an error. If I select each face except for the triangles, it unwraps without issue. I think this may be a Blender 3.0 related issue because in earlier versions I seem to recall DreamUV would try to fit the triangles into the hotspot map anyways, and wouldn't give errors. Here is the error it gives me:

DUV_HotSpot.py, line 184, in execute is_rect = DUV_utils.square_fit(context)

DUV_Utils.py, line 617, in square_fit bmesh.updated_edit_mesh(me, True)

TypeError: update_edit_mesh() takes at most 1 positional argument (2 given)

I tried this also with ngons, and got the same error. It seems to give this error when there are any faces that are not quads, which seems new to this version of the plugin (at least as far as I can recall).

All in all it's a fairly minor problem as it is easy enough to only select the quads for unwrapping in most cases, but I thought you should be aware of it.

JoelGodin commented 2 years ago

Can you try the fork at https://github.com/Draise14/DreamUV I believe he fixed the update_edit_mesh() error and it has not been merged yet to leukbaars master. I used it and it has worked well, but not sure about the tri's.

JClarkRichardson commented 2 years ago

Ok, I gave it a shot, and it gave me the same error as described above. I took a cube, triangulated its faces, and tried unwrapping. If I left the cube's faces as quads, it worked fine. I also tried it with a cylinder (with the caps as ngons) and got the same error if I had the caps selected.

leukbaars commented 1 year ago

should be fixed in latest update